Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discussion URL on datasets and spaces #1465

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented May 8, 2023

FIX #1463 (cc @mishig25).

@Wauplin Wauplin requested a review from mishig25 May 8, 2023 13:02
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 8, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (69054c6) 82.55% compared to head (954f25f) 82.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   82.55%   82.58%   +0.03%     
==========================================
  Files          53       53              
  Lines        5640     5640              
==========================================
+ Hits         4656     4658       +2     
+ Misses        984      982       -2     
Impacted Files Coverage Δ
src/huggingface_hub/community.py 90.90% <100.00%> (+2.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! Thanks so much for fixing it

@Wauplin Wauplin merged commit 62351bc into main May 8, 2023
@Wauplin Wauplin deleted the 1463-fix-discussion-url branch May 8, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion.url is being wrong
3 participants