-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes for push_to_hub_fastai to use the new http-based approach. #1040
Add changes for push_to_hub_fastai to use the new http-based approach. #1040
Conversation
Will fix #996. |
The documentation is not available anymore as the PR was closed or merged. |
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
+ Coverage 83.53% 83.69% +0.15%
==========================================
Files 37 37
Lines 3918 3919 +1
==========================================
+ Hits 3273 3280 +7
+ Misses 645 639 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for tackling this!
e79744c
to
6e45934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nandwalritik for the changes ! I think we are almost good to go 🔥
What I see left (sorry if I just realize now):
- Update the first line of the docstring. Current is
Upload learner checkpoint files to the Hub while synchronizing a local clone of the repo in
:obj:`repo_id`.
which is not correct anymore since we are not synchronizing a local clone of the repo.
- Add a description of
allow_patterns
andignore_patterns
arguments in docstring:
(...)
Use `allow_patterns` and `ignore_patterns` to precisely filter which files should be
pushed to the hub. See [`upload_folder`] reference for more details.
(...)
Args:
(...)
allow_patterns (`List[str]` or `str`, *optional*):
If provided, only files matching at least one pattern are pushed.
ignore_patterns (`List[str]` or `str`, *optional*):
If provided, files matching any of the patterns are not pushed.
- It seems you have a small merge conflict to solve. You should do something like this locally:
# Sync your fork
git fetch upstream
git checkout main
git merge upstream/main
# Merge into your branch
git checkout http_based_push_to_hub_for_fastai
git merge main
# and then resolve conflicts
# and then apply linters (`make quality` and `make style`)
For more details, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork.
Thanks @Wauplin for guiding, I have added the changes, let me know if I missed something. |
@nandwalritik you're welcome, thanks for working on it. Otherwise I'll merge that on Monday. |
Thanks for finalizing the details @nandwalritik . I just merged it :) |
Fixes #996
This PR updates the fastai integration from git-based to the new http-based approach.
Who can review:
@Wauplin