1055 deprecate private and repo type in repository class #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov Report
@@ Coverage Diff @@
## main #1057 +/- ##
==========================================
+ Coverage 83.97% 84.01% +0.03%
==========================================
Files 38 38
Lines 4099 4109 +10
==========================================
+ Hits 3442 3452 +10
Misses 657 657
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LysandreJik
requested changes
Sep 16, 2022
Wauplin
deleted the
1055-deprecate-private-and-repo-type-in-repository-class
branch
|
Thanks for the review :) I changed the wording and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1055.
I also start to think that
clone_frommethod should be a standalone private helper (e.g.: not meant to be used by end users, just via theclone_fromattribute at init). This would avoid having HF-specific attributes likerepo_typeinRepository: once initialized the value is not needed anymore.