-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_hf_file_metadata to fetch metadata from the Hub #1058
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Codecov Report
@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
+ Coverage 83.97% 83.99% +0.02%
==========================================
Files 38 38
Lines 4099 4117 +18
==========================================
+ Hits 3442 3458 +16
- Misses 657 659 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for working on this! Just left some small nits on docstrings.
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @Wauplin!
Thanks both for the review, I'm merging :) |
Fix #1028.
By using the officially supported
get_hf_file_metadata
,transformers
can stop using_request_for_retry
and_normalize_etag
private methods (cc @sgugger @LysandreJik).Edit: reverted back to Draft PR as the tests are not implemented.