Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy helper 'install_lfs_in_userspace' #1059

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Remove legacy helper 'install_lfs_in_userspace' #1059

merged 1 commit into from
Sep 16, 2022

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 16, 2022

Fix #1056 (cc @KOLANICH)

@Wauplin Wauplin requested a review from LysandreJik September 16, 2022 12:36
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 16, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

LysandreJik
LysandreJik approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @Wauplin

@LysandreJik LysandreJik merged commit 7017bf2 into main Sep 16, 2022
@LysandreJik LysandreJik deleted the 1056-remove-install-lfs-in-userspace branch September 16, 2022 16:39
@KOLANICH
Copy link

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of as much subprocess as possible, and get rid of passing args via CLI where possible
4 participants
@Wauplin @HuggingFaceDocBuilderDev @KOLANICH @LysandreJik