Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort repos/revisions by age in delete-cache #1063

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 19, 2022

Suggested in #1046 (comment).

To be honest I'm not really opinionated so let's do by age as suggested @stas00.

Mind reviewing @stas00 ? :)

@Wauplin Wauplin requested a review from stas00 September 19, 2022 07:27
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 19, 2022

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1063 (86ae103) into main (6f1e813) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
+ Coverage   84.16%   84.17%   +0.01%     
==========================================
  Files          38       38              
  Lines        4098     4102       +4     
==========================================
+ Hits         3449     3453       +4     
  Misses        649      649              
Impacted Files Coverage Δ
src/huggingface_hub/commands/delete_cache.py 90.32% <100.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Thank you, @Wauplin

@Wauplin Wauplin merged commit cb4dd3a into main Sep 19, 2022
@Wauplin Wauplin deleted the 1025-sort-delet-cache-repos branch September 19, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants