Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default model_name in metadata_update #1157

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Use default model_name in metadata_update #1157

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e69565b
set default model name if none is provided
Nov 4, 2022
9a6f7ba
Merge branch 'main' into fix-update-metadata-missing-name
lvwerra Nov 4, 2022
db920f3
Update src/huggingface_hub/repocard.py
lvwerra Nov 4, 2022
b899fa8
add tests
Nov 4, 2022
4d46b7e
update modelcard docstring
Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/huggingface_hub/repocard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,9 @@ def metadata_update(

for key, value in metadata.items():
if key == "model-index":
# if the new metadata doesn't include a name, either use existing one or repo name
if "name" not in value[0]:
value[0]["name"] = getattr(card, "model_name", repo_id.split("/")[-1])
lvwerra marked this conversation as resolved.
Show resolved Hide resolved
model_name, new_results = model_index_to_eval_results(value)
if card.data.eval_results is None:
card.data.eval_results = new_results
Expand Down