Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Authorization header when following redirects #1345

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Remove Authorization header when following redirects #1345

merged 1 commit into from
Feb 17, 2023

Conversation

XciD
Copy link
Member

@XciD XciD commented Feb 16, 2023 •
edited
Loading

I thought that

huggingface_hub/src/huggingface_hub/file_download.py

Line 1137 in 21a1e37

headers.pop("authorization", None)
was enough

Seems like we have multiple path for the same end

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 16, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@XciD XciD requested a review from Wauplin February 16, 2023 21:32
@Wauplin Wauplin merged commit 4d3d150 into main Feb 17, 2023
@Wauplin Wauplin deleted the remove-authorization-when-redirect branch February 17, 2023 08:38
Wauplin pushed a commit that referenced this pull request Feb 17, 2023
@XciD @Wauplin
Remove Authorization header when following redirects (#1345)
5773d65
@julien-c
Copy link
Member

nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XciD @HuggingFaceDocBuilderDev @julien-c @Wauplin