Expose RepoCard at top level + few qol improvements
#1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
merveenoyan
approved these changes
Feb 21, 2023
src/huggingface_hub/repocard.py
Outdated
| class SpaceCard: | ||
| """Space card is an alias for [`RepoCard`]. | ||
|
|
||
| At the moment, it does not implement any specific logic. `SpaceCard` is defined for |
There was a problem hiding this comment.
Do you think it makes sense to have Space-specific attributes in RepoCard under this instead? (e.g. like the one that tells us about duplicate)
There was a problem hiding this comment.
Defintely. Not useless to have a separate class in the end 😄
There was a problem hiding this comment.
@merveenoyan @julien-c added it in d5e71bb
nateraw
approved these changes
Feb 21, 2023
|
Thanks for the reviews and feedback @merveenoyan @nateraw |
Wauplin
deleted the
1348-repo-card-at-top-level-and-few-qol-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1348.
No need to add a
SpaceCardclass, it wouldn't have any additional features.I took the opportunity to add a few QOL improvement to the
CardDataobject (.get,__getitem__,__setitem__,__contains__,.pop). More of these could be added but honestly not worth the hassle (those 5 cover 99% of the use cases). Could have been simpler to just inherit fromdictbut this way we can explicitly add an "export" step when serializing the metadata.Added some tests and completed a docstring.