Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MC headings #1367

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Updating MC headings #1367

merged 1 commit into from
Feb 28, 2023

Conversation

EziOzoani
Copy link
Contributor

@EziOzoani EziOzoani commented Feb 28, 2023

Updating the Markdown headings so it tracks with the HTML
(see this thread)

Fixes: #1366

Updating the Markdown headings so it tracks with the HTML
@EziOzoani EziOzoani added the documentation Improvements or additions to documentation label Feb 28, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 28, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion makes total sense!
Looks good to me. Could you update the Dataset Card template as well? 🙏 => https://github.com/huggingface/huggingface_hub/blob/ezi/src/huggingface_hub/templates/datasetcard_template.md

@EziOzoani
Copy link
Contributor Author

@Wauplin for this update I think the dataset card is already okay, there is only one singular # i.e h1 iirc in html

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this update I think the dataset card is already okay, there is only one singular # i.e h1 iirc in html

Oops sorry for that, I have been too quick in my review then. It's approved! :)

@Wauplin Wauplin merged commit b93803f into main Feb 28, 2023
@Wauplin Wauplin deleted the ezi branch February 28, 2023 16:13
@EziOzoani
Copy link
Contributor Author

No problemo
thanks for the merge @Wauplin , super appreciate d💃💃

@NimaBoscarino
Copy link
Contributor

Yay this is fantastic! Thanks for doing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Markdown '#' in MC template
4 participants