Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model card template: Move model usage instructions out of Bias section #1400

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

NimaBoscarino
Copy link
Contributor

Not sure that ### How to Get Started with the Model belongs under the Bias, Risks, and Limitations section, so this PR changes it from a H3 to an H2.

@NimaBoscarino NimaBoscarino requested a review from EziOzoani March 20, 2023 18:19
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 20, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (c300b61) 84.18% compared to head (67635f9) 84.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
+ Coverage   84.18%   84.26%   +0.08%     
==========================================
  Files          48       48              
  Lines        4963     4963              
==========================================
+ Hits         4178     4182       +4     
+ Misses        785      781       -4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin
Copy link
Contributor

Wauplin commented Mar 20, 2023

cc-ing @EziOzoani @meg-huggingface for review on this PR

Has it been discussed on Slack btw? (if yes, I would refer to this discussion for more context, otherwise I'm fine with having only this PR)

@NimaBoscarino
Copy link
Contributor Author

Nope, hasn't been discussed on Slack! I just ran into this while working on something and figured it was probably a mistake or a typo.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agree with you, seems like a typo.
Approved the PR but please wait to get another approval from @EziOzoani or @meg-huggingface before merging, just to be sure :)

@Wauplin Wauplin merged commit 1e3c731 into main Mar 22, 2023
@Wauplin Wauplin deleted the model-card-usage branch March 22, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants