Raise issue if trying to upload .git/ folder + ignore .git/ folder in upload_folder
#1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lewtun
approved these changes
Mar 24, 2023
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Wauplin
commented
Mar 24, 2023
LysandreJik
approved these changes
Mar 24, 2023
|
Thanks for the reviews @lewtun @LysandreJik! It'll avoid mistakes in the future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1401 and #1402 (thanks @lewtun for reporting it).
This PR:
CommitOperationAddandCommitOperationDelete=> it is not possible to upload/delete a file in the.git/folder. Server would not accept it anyway but let's raise an issue early..git/folder when uploading withupload_folderOne thing that would be cool before having a
huggingface-cli pushcommand would be to comply with the.gitignorespecification. However this is not straightforward (cannot be converted to a list of allow_patterns/ignore_patterns that easily). I have found a gitignore_parser that does the trick but it would add another dependency for which I don't know much about the quality of it. Let's keep this discussion for later.Note: I also refactored a few tests in
hf_apito be more consistent with creating/deleting repos. Not exhaustive but it's still cleaner.