-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: notebook_login() does not update UI on Databricks #1414
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Hey @fwetdb thanks for working on this! At first glance PR looks good :) I'll make some tests in different environments (colab/jupyter, python3.7/3.10) soon and get back to you for a proper review. If you see some code quality issues, don't worry I can handle them. |
Hi @fwetdb, I made some tests and it works great! I think we are good to go. I pushed some code to your branch. Instead of the @osanseviero could you have a second look please as it impact all our notebook users? I made a colab for you to quickly test the new UI. The main change is that the returned message ("you're logged in !") is not printed from the terminal but displayed as a widget (and centered). For context, the goal is to avoid (For testing, I tried jupyter notebook on Python 3.7 and 3.10 + tried google Colab. Is there another notebook we should try?) |
It looks ok from my side! Thanks for the fix |
LGTM too and quite happy that we improve our support of Databricks / Databricks notebooks 👍 |
Thank you @Wauplin and everyone else involved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, thanks @fwetdb for double-checking this!
I'm merging the PR then 🎉
Fixes 1384
The PR adjusts notebook_login() to use the ipywidgets Box output to print the feedback.
This enables the logic to work in all notebooks that are compatible with ipywidgets - including Databricks where
clear_output
does not work.Examples for the code flow: