Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log as warning when waiting for ongoing commands #1415

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 29, 2023

Fix #1412 (see discussion in huggingface/diffusers#2851).

@Wauplin Wauplin requested review from yiyixuxu and LysandreJik March 29, 2023 15:56
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 29, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (26dbe09) 84.13% compared to head (8272d6f) 84.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   84.13%   84.13%           
=======================================
  Files          48       48           
  Lines        4991     4991           
=======================================
  Hits         4199     4199           
  Misses        792      792           
Impacted Files Coverage Δ
src/huggingface_hub/repository.py 78.20% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wauplin !

@Wauplin Wauplin merged commit f5ddbec into main Mar 29, 2023
@Wauplin Wauplin deleted the 1412-log-as-warning-when-waiting-for-ongoing-commands branch March 29, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log at warning level when waiting for commands to finish
3 participants