Remove deprecated code + adapt tests #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
May 15, 2023
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 0.14 release.
Breaking changes:
list_models,list_datasetsandlist_spacesreturn an iterable instead of a list (lazy-loading of paginated results)cardDatainlist_datasets. Should usefullinstead.Both changes should have been removed in 0.14 already but I forgot 😇. Since they were deprecated I hope the change will not brake too much warnings. I'll still advertise internally, just in case.
(I also modified some tests to stop listing all models/datasets/spaces from the Hub just to check it returns more than 100 results. This should save 2-3min on the overall CI 🤯)