Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve broken link to 'filesystem' #1461

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

tomaarsen
Copy link
Member

Hello again!

Pull Request overview

  • Resolve broken link to filesystem instead of hf_file_system.

Details

On https://huggingface.co/docs/huggingface_hub/guides/overview, click the HfFileSystem option and it'll break.

This originates from a slight error in https://github.com/huggingface/huggingface_hub/pull/1420/files#diff-e8d4686d1d8a67d6970c799e668524f40ab243af1900c378687822cb3ccd9e0cR46

Apologies for the EOF change, I quickly made this patch via the GitHub web interface, and it decided to make that change for me...

  • Tom Aarsen

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 1, 2023

The documentation is not available anymore as the PR was closed or merged.

@tomaarsen
Copy link
Member Author

This is the previously failing overview page. The HfFileSystem button works now.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attention to details @tomaarsen !

@Wauplin Wauplin merged commit aeef5d6 into huggingface:main May 1, 2023
@tomaarsen tomaarsen deleted the patch-1 branch May 1, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants