Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _hf_folder.py #1487

Merged
merged 2 commits into from
May 30, 2023
Merged

Update _hf_folder.py #1487

merged 2 commits into from
May 30, 2023

Conversation

SimonKitSangChu
Copy link
Contributor

Allow permission error, especially for HPC environment

@SimonKitSangChu
Update _hf_folder.py
09bd5fd 
Allow permission error, especially for HPC environment
Wauplin
Wauplin approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense even if it's a corner case. Thanks for opening a PR! :)

I made a small change to ignore any Exception, just in case. Worth case scenario, the user has to log in again.

src/huggingface_hub/utils/_hf_folder.py Outdated Show resolved Hide resolved
Wauplin
Wauplin approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense even if it's a corner case. Thanks for opening a PR! :)

I made a small change to ignore any Exception, just in case. Worth case scenario, the user has to log in again.

@Wauplin Wauplin merged commit 4344b26 into huggingface:main May 30, 2023
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonKitSangChu @HuggingFaceDocBuilderDev @Wauplin