Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code for v0.16.x #1492

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Remove deprecated code for v0.16.x #1492

merged 1 commit into from
Jun 2, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jun 1, 2023

Not much to remove which is I think a good sign that huggingface_hub is getting more mature :)

  • force to use kwargs in ModelHubMixin (instead of passing everything a positional arg)
  • not possible anymore to pass model_id as username/repo_name@revision in ModelHubMixin

(+2 type annotations fixes)

@Wauplin Wauplin requested a review from LysandreJik June 1, 2023 16:09
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b347dfd) 82.24% compared to head (226aba8) 82.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1492   +/-   ##
=======================================
  Coverage   82.24%   82.24%           
=======================================
  Files          55       55           
  Lines        5913     5904    -9     
=======================================
- Hits         4863     4856    -7     
+ Misses       1050     1048    -2     
Impacted Files Coverage Δ
src/huggingface_hub/hub_mixin.py 96.00% <ø> (+1.95%) ⬆️
src/huggingface_hub/__init__.py 75.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Cool to see that the API is stabilizing itself 🎉

@Wauplin Wauplin merged commit 0410930 into main Jun 2, 2023
@Wauplin Wauplin deleted the prepare-for-0.16 branch June 2, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants