Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage to overwrite CommitScheduler.push_to_hub #1506

Merged
merged 15 commits into from
Jun 14, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jun 12, 2023

Demo Space for working implementation examples: https://huggingface.co/spaces/Wauplin/space_to_dataset_saver

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b4e01b0) 82.18% compared to head (13092e7) 82.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          57       57           
  Lines        6089     6095    +6     
=======================================
+ Hits         5004     5009    +5     
- Misses       1085     1086    +1     
Impacted Files Coverage Δ
src/huggingface_hub/_commit_scheduler.py 96.55% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@Wauplin Wauplin requested a review from stevhliu June 13, 2023 09:35
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, left a few minor nits! 👍

docs/source/guides/upload.mdx Outdated Show resolved Hide resolved
docs/source/guides/upload.mdx Outdated Show resolved Hide resolved
docs/source/guides/upload.mdx Outdated Show resolved Hide resolved
docs/source/guides/upload.mdx Outdated Show resolved Hide resolved
src/huggingface_hub/_commit_scheduler.py Outdated Show resolved Hide resolved
Wauplin and others added 6 commits June 13, 2023 19:51
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
…huggingface_hub into extendable-commit-scheduler
@Wauplin Wauplin merged commit e0d9505 into main Jun 14, 2023
@Wauplin Wauplin deleted the extendable-commit-scheduler branch June 14, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants