Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation to inference client #1608

Merged

Conversation

martinbrose
Copy link
Contributor

Add translation to HuggingFace🤗 Hub

References #1539

This is an ongoing list of model tasks to implement in the Hugging Face Hub inference client. Each task is planned to be its own PR. The task for this is translation.

Key Features

  • Modifies _client.py to call a translation model.
  • Modifies testing and documentation to reflect changes.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 20, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.49% ⚠️

Comparison is base (c716714) 82.31% compared to head (90c62db) 81.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   82.31%   81.83%   -0.49%     
==========================================
  Files          62       62              
  Lines        6984     6990       +6     
==========================================
- Hits         5749     5720      -29     
- Misses       1235     1270      +35     
Files Changed Coverage Δ
...gingface_hub/inference/_generated/_async_client.py 57.70% <33.33%> (-0.33%) ⬇️
src/huggingface_hub/inference/_client.py 80.09% <100.00%> (+0.28%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean PR! I took care of the merge conflicts and tested it locally. Works like a charm ! Thanks @martinbrose 🤗

@Wauplin Wauplin merged commit e6f6760 into huggingface:main Sep 6, 2023
@martinbrose martinbrose deleted the 1539-InferenceClient-translation branch September 6, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants