Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill mask to inference client #1613

Merged

Conversation

martinbrose
Copy link
Contributor

@martinbrose martinbrose commented Aug 21, 2023

Add fill-mask to HuggingFace🤗 Hub

References #1539

This is an ongoing list of model tasks to implement in the Hugging Face Hub inference client. Each task is planned to be its own PR. The task for this is fill-mask.

Key Features

  • Modifies _client.py to call a fill-mask model.
  • Modifies testing and documentation to reflect changes.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 21, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +32.23% 🎉

Comparison is base (0fbbf6b) 49.57% compared to head (f735f4f) 81.81%.

❗ Current head f735f4f differs from pull request most recent head 125906a. Consider uploading reports for the commit 125906a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1613       +/-   ##
===========================================
+ Coverage   49.57%   81.81%   +32.23%     
===========================================
  Files          62       60        -2     
  Lines        7014     6790      -224     
===========================================
+ Hits         3477     5555     +2078     
+ Misses       3537     1235     -2302     
Files Changed Coverage Δ
...gingface_hub/inference/_generated/_async_client.py 58.37% <25.00%> (+36.14%) ⬆️
src/huggingface_hub/inference/_client.py 79.51% <100.00%> (+55.65%) ⬆️
src/huggingface_hub/inference/_types.py 96.15% <100.00%> (-1.15%) ⬇️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more! 🙏 🤗

@Wauplin Wauplin merged commit 91038a2 into huggingface:main Sep 6, 2023
@martinbrose martinbrose deleted the 1539-InferenceClient-fill-mask branch September 6, 2023 16:40
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants