Fix fsspec tests in ci #1635
Merged
Fix fsspec tests in ci #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks for the quick review @lhoestq :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsspec.existslogic catches ALL exceptions which can lead to unexpected behaviors. For example, we raise aNotImplementedErrorwhen trying to list repositories (which is not supported). This PR adapts the logic to raise on any exception except theNotImplementedError.First discovered about it since
fsspec.glob()logic has been changed in fsspec/filesystem_spec#1329 (released in 2023.9.0). It now relies on.exists()instead of.find()which catch all exceptions, including the NotImplementedError (making the CI fail)cc @mariosasko please let me know if you think such a change will lead to unexpected behavior as it's a quite low-level method. I happy to revisit this PR if you have a better idea. I found catching all exceptions quite unnatural in general but maybe I'm wrong.