Distinguish _bytes_to_dict and _bytes_to_list + fix issues
#1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incoherence reported by @martinbrose in #1606 (comment). In the inference client logic, we have a
_bytes_to_dicthelper that is annotated as returning an"Image"which is wrong.This PR changes the return type of
_bytes_to_dictand adds a_bytes_to_listhelper. Both have the exact same logic to decode JSON-encoded data. The advantage of having 2 helpers is to help devs + mypy understand what is the expected data format from the server. If the data is not in a valid form, no issue is raised at runtime.