-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 [i18n-DE] Translate docs to German #1646
🌐 [i18n-DE] Translate docs to German #1646
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Wow, thanks for the impressive effort on the translation @martinbrose ! I'll have a look to the PR (at least for the structure) once the current release is done. |
Gently pinging @patrickvonplaten @philschmid if you have time for a German-docs review 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sehr gut!
Total unwichtig, aber ich finde "der [Hugging Face] Hub" klingt merkwürdig, ich hätte "das Hub" verwendet. "Der Hub" klingt so wie die Substantivierung von "Heben", also wie singular "Hub", plural "Hübe". Ich hätte auch eher die Du-Form gewählt als die Sie-Form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @martinbrose 🤗
I only reviewed the technical aspect of the PR which overall looks good (see comments). One more thing to do is to update the github config so that the DE docs get built. You need to update this workflow and this one to add "de" as a language (as done in transformers
). Thanks in advance!
Hi @BenjaminBossan, danke für Dein Feedback! Ich hatte auch erst bei dem richtigen Artikel für Hub gestutzt. Bei dem "Du" vs "Sie" habe ich mich an der deutschen Übersetzung der Transformers Bibliothek orientiert: https://huggingface.co/docs/transformers/v4.33.0/de/quicktour Viele Grüsse |
So maybe a more general question to the others: Do we prefer the more formal German "Sie" or the informal German "du"? It's like "vous" vs "tu" in French. The transformers docs use "Sie" and "vous" but IMHO it sounds very old school and incongruent with the general tone we use.
TIL! |
So I went to read French docs in |
Thanks for making the changes @martinbrose ! PR looks almost good to merge for me. Last thing to do, could you update the github workflow files to add "de" as a supported language as describe in #1646 (review)? Thanks in advance! |
Done. |
Ok, I leave it at "Sie" for now. It's an easy change to "Du" if this is decided further along. |
This is a good job for an LLM ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final review done! Thanks for the effort @martinbrose, it's time to merge and publish that 🎉 🎉 🎉
References #1645
Key features
README
to German;index
,installation
,quick-start
) to German;./guides
) to German