Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-DE] Translate docs to German #1646

Merged
merged 22 commits into from
Sep 19, 2023

Conversation

martinbrose
Copy link
Contributor

@martinbrose martinbrose commented Sep 7, 2023

References #1645

Key features

  • Translates main README to German;
  • Translates the main landing docs (index, installation, quick-start) to German;
  • Translates the How-To-Guides (./guides) to German

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 7, 2023

The documentation is not available anymore as the PR was closed or merged.

@martinbrose martinbrose changed the title Translate main base docs to German Translate docs to German Sep 9, 2023
@Wauplin
Copy link
Contributor

Wauplin commented Sep 11, 2023

Wow, thanks for the impressive effort on the translation @martinbrose ! I'll have a look to the PR (at least for the structure) once the current release is done.

@Wauplin
Copy link
Contributor

Wauplin commented Sep 11, 2023

Gently pinging @patrickvonplaten @philschmid if you have time for a German-docs review 🤗

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr gut!

@BenjaminBossan
Copy link
Member

Total unwichtig, aber ich finde "der [Hugging Face] Hub" klingt merkwürdig, ich hätte "das Hub" verwendet. "Der Hub" klingt so wie die Substantivierung von "Heben", also wie singular "Hub", plural "Hübe".

Ich hätte auch eher die Du-Form gewählt als die Sie-Form.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @martinbrose 🤗

I only reviewed the technical aspect of the PR which overall looks good (see comments). One more thing to do is to update the github config so that the DE docs get built. You need to update this workflow and this one to add "de" as a language (as done in transformers). Thanks in advance!

docs/source/de/_redirects.yml Outdated Show resolved Hide resolved
README_de.md Show resolved Hide resolved
@martinbrose
Copy link
Contributor Author

Total unwichtig, aber ich finde "der [Hugging Face] Hub" klingt merkwürdig, ich hätte "das Hub" verwendet. "Der Hub" klingt so wie die Substantivierung von "Heben", also wie singular "Hub", plural "Hübe".

Ich hätte auch eher die Du-Form gewählt als die Sie-Form.

Hi @BenjaminBossan,

danke für Dein Feedback!

Ich hatte auch erst bei dem richtigen Artikel für Hub gestutzt.
Aber denke "der Hub" stimmt mit dem Duden überein, welcher dies für zwei Varianten so benutzt:

  1. der Hub als der zentrale Umschlagplatz / der Knotenpunkt
  2. der Hub als der Digital Hub

Bei dem "Du" vs "Sie" habe ich mich an der deutschen Übersetzung der Transformers Bibliothek orientiert: https://huggingface.co/docs/transformers/v4.33.0/de/quicktour
Aber ich ändere es auch gerne zu "Du" falls wir zu dem Konsens kommen.

Viele Grüsse

@BenjaminBossan
Copy link
Member

Bei dem "Du" vs "Sie" habe ich mich an der deutschen Übersetzung der Transformers Bibliothek orientiert: https://huggingface.co/docs/transformers/v4.33.0/de/quicktour
Aber ich ändere es auch gerne zu "Du" falls wir zu dem Konsens kommen.

So maybe a more general question to the others: Do we prefer the more formal German "Sie" or the informal German "du"? It's like "vous" vs "tu" in French. The transformers docs use "Sie" and "vous" but IMHO it sounds very old school and incongruent with the general tone we use.

Ich hatte auch erst bei dem richtigen Artikel für Hub gestutzt.
Aber denke "der Hub" stimmt mit dem Duden überein, welcher dies für zwei Varianten so benutzt:

TIL!

@Wauplin
Copy link
Contributor

Wauplin commented Sep 14, 2023

So maybe a more general question to the others: Do we prefer the more formal German "Sie" or the informal German "du"? It's like "vous" vs "tu" in French. The transformers docs use "Sie" and "vous" but IMHO it sounds very old school and incongruent with the general tone we use.

So I went to read French docs in transformers (and some Google docs) to get an idea. It feels formal but I'm fine with it TBH. It has more or less the same tone as reading a recipe so I was not shocked by it. I'd say both are fine for me, with a slight preference for keeping the same tone as the existing HF 🇩🇪 docs (so "Sie"?).
In any case, it's not that much of a big deal IMO. @martinbrose you've done the work, I trust you to chose whichever you feel the most comfortable with.

@Wauplin Wauplin changed the title Translate docs to German 🌐 [i18n-DE] Translate docs to German Sep 15, 2023
@Wauplin
Copy link
Contributor

Wauplin commented Sep 18, 2023

Thanks for making the changes @martinbrose ! PR looks almost good to merge for me. Last thing to do, could you update the github workflow files to add "de" as a supported language as describe in #1646 (review)? Thanks in advance!

@martinbrose
Copy link
Contributor Author

Thanks for making the changes @martinbrose ! PR looks almost good to merge for me. Last thing to do, could you update the github workflow files to add "de" as a supported language as describe in #1646 (review)? Thanks in advance!

Done.

@martinbrose
Copy link
Contributor Author

So maybe a more general question to the others: Do we prefer the more formal German "Sie" or the informal German "du"? It's like "vous" vs "tu" in French. The transformers docs use "Sie" and "vous" but IMHO it sounds very old school and incongruent with the general tone we use.

So I went to read French docs in transformers (and some Google docs) to get an idea. It feels formal but I'm fine with it TBH. It has more or less the same tone as reading a recipe so I was not shocked by it. I'd say both are fine for me, with a slight preference for keeping the same tone as the existing HF 🇩🇪 docs (so "Sie"?). In any case, it's not that much of a big deal IMO. @martinbrose you've done the work, I trust you to chose whichever you feel the most comfortable with.

Ok, I leave it at "Sie" for now. It's an easy change to "Du" if this is decided further along.

@BenjaminBossan
Copy link
Member

Ok, I leave it at "Sie" for now. It's an easy change to "Du" if this is decided further along.

This is a good job for an LLM ;-)

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review done! Thanks for the effort @martinbrose, it's time to merge and publish that 🎉 🎉 🎉

@Wauplin Wauplin merged commit 609bbe4 into huggingface:main Sep 19, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants