-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 [i18n-KO] Translated README, landing docs to Korean #1667
Conversation
README.md
to Korean6eb8e74
to
dc77829
Compare
Hi @wonhyeongseo, thanks for working on this PR! |
Hi @Wauplin , really appreciate it. I will be able to translate seven of the guides (highlighted in the README) by this week Friday. This is quite different from what we have done previously, which was one document at a time. But like you said, we together will figure out a way. I will be sure to ask questions on the content throughout the process. Please stay tuned 😆 Best regards from Korea, |
That's a big effort! Thanks for the commitment to make those docs available to more ML-enthusiast! |
Opening the remaining Hub docs to our mentees and the community, as requested in our Tuesday meeting. This PR is ready for review, have a wonderful day @Wauplin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great effort @wonhyeongseo! I've reviewed the PR but only from a high-level aspect (checking links and configs). Found an inconsistency for overview and upload guides but apart from that it looks good to me. I like the idea of a in_translation
page so that we already get an first version to iterate on.
Have a great day as well 🤗
- local: guides/overview | ||
title: 개요 | ||
- local: guides/download | ||
title: 파일 다운로드하기 | ||
- local: in_translation | ||
title: (번역 중) Upload files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guides/overview
has not being added to this PR. Would be best to either remove it (set toin_translation
) or add a translated version of the overview page- The upload guide has being uploaded to this PR but entirely in English. Maybe just a mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Wauplin, thank you for your helpful feedback!
There was a mistake in deleting overview.md
instead of upload.md
. It has been fixed in a new commit.
The document will be proof-read for the next 3 days. Please feel free to share any suggestions or comments. Otherwise, I think we can merge it after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for making the change @wonhyeongseo :)
Approved the PR but as you said, let's wait for proof-reading before merging.
* delete upload.md
018d536
to
fd6868b
Compare
Hello @Wauplin, hope you are doing well. |
And... it's live! https://huggingface.co/docs/huggingface_hub/main/ko/index 🚀 Well done for this first doc sprint @wonhyeongseo ! |
very cool great job @wonhyeongseo !! |
What does this PR do?
Key features
README
to Korean;Part of #1626
Before reviewing
[[lowercased-header]]
)Who can review? (Initial)
Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)