Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes filtering by tags with list_models and adds test case #1673

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fixes filtering by tags with list_models and adds test case #1673

merged 3 commits into from
Sep 19, 2023

Conversation

martinbrose
Copy link
Contributor

Fixes #1668

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 17, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@Wauplin Wauplin reopened this Sep 18, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 18, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

Wauplin
Wauplin approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me! Thanks for investigating + fixing the issue and to add a unit test on top of that 😄 Let's wait for the CI to complete and it'll be good to merge :)

@Wauplin Wauplin merged commit adef26d into huggingface:main Sep 19, 2023
@martinbrose martinbrose deleted the 1668-ModelFilter-fix branch September 19, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Filtering models by tags using ModelFilter doesn't work
3 participants
@martinbrose @HuggingFaceDocBuilderDev @Wauplin