Adding the ability to configure the timeout of get request #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Hey @Shahafgo! Thanks for this very clean PR!
I reviewed and made some small comments. Mostly to add a bit more explanation in the docs + remove some duplicated logic. I like how you separated default value and user value. Looks good overall :)
Comment on lines
+318
to
+319
| info["HF_HUB_ETAG_TIMEOUT"] = constants.HF_HUB_ETAG_TIMEOUT | ||
| info["HF_HUB_DOWNLOAD_TIMEOUT"] = constants.HF_HUB_DOWNLOAD_TIMEOUT |
There was a problem hiding this comment.
Really like this, thank you!
Update HF_HUB_ETAG_TIMEOUT documentation Co-authored-by: Lucain <lucainp@gmail.com>
Update HF_HUB_DOWNLOAD_TIMEOUT documentation Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Wauplin
approved these changes
Oct 12, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
|
And it's merged! Thanks for the work @Shahafgo ! 🚀 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR purpose is to adding the ability to configure the timeout of requests during the download file operation