Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly configures every in test_sync_and_squash_history #1731

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Properly configures every in test_sync_and_squash_history #1731

merged 1 commit into from
Oct 13, 2023

Conversation

jamesbraza
Copy link
Contributor

I discovered test_sync_and_squash_history was improperly configured:

  • every was set at 1-sec, but its comment said 0.1-sec
  • A time.sleep below was set for 0.5-sec

This led to a race condition. This solves one of the CI issues hit in #1727.

@jamesbraza jamesbraza mentioned this pull request Oct 12, 2023
Closed
Wauplin
Wauplin approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yes, true. Thanks for fixing this @jamesbraza! 🤗

@Wauplin Wauplin merged commit 865ace1 into huggingface:main Oct 13, 2023
@jamesbraza jamesbraza deleted the fixing-test-sync-squash-history branch October 13, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @Wauplin