Fix Space runtime on static Space #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
julien-c
reviewed
Oct 17, 2023
Comment on lines
+119
to
+122
| self.hardware = data.get("hardware", {}).get("current") | ||
| self.requested_hardware = data.get("hardware", {}).get("requested") | ||
| self.sleep_time = data.get("gcTimeout") | ||
| self.storage = data.get("storage") |
There was a problem hiding this comment.
syntax is not super pretty but LGTM
There was a problem hiding this comment.
I'll yet you open an issue on https://github.com/python/cpython and in the meantime merge this PR 😄
There was a problem hiding this comment.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
huggingface_hub.get_space_runtimewas previously raising an exception on Static Space because hardware is not returned by the server. This PR fixes it by setting hardware to None.cc @clefourrier @hysts (from internal slack)