-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor doc fixes #1775
Merged
Merged
Minor doc fixes #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and opening a PR @pcuenca ! Looks better now :)
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Wauplin
added a commit
that referenced
this pull request
Oct 26, 2023
* removed tags from endpoint tests * removed tags from endpoints * removed tags from hf_api * removed tags from docstrings in endpoint_helpers * removed tags from hf_api * removed model search argument from test_hf_api * removed ModelSearchArguments and DataSearchArguments * removed DatasetSearchArguments and ModelSearchArguments * removed DatasetSearchArguments and * removed ModelSearchArguments and DatasetSearchArguments from the docs * Revert "removed DatasetSearchArguments and" This reverts commit ce6b91b. * removed tags from __init__.py * ran make style * Removed ## How to explore filter options ? section * Revert "removed tags from __init__.py" This reverts commit ad1a31c. Reverting removal get_dataset_tags and get_model_tags for comment 2 * Revert "removed DatasetSearchArguments and ModelSearchArguments" This reverts commit fbf6dd0. * Revert "removed tags from __init__.py" This reverts commit ad1a31c. * Revert "removed tags from hf_api" This reverts commit 2cefee1. * Revert "removed tags from hf_api" This reverts commit dd3b8f1. * Removed attribute dictionary from imports and removed model search argument class * Complete removed class AttributeDictionary(dict): * Removed attribute dictionary tests * Updating ModelTags and DatasetTags so that they just return the raw dictionary * Removed final DatasetTags import * Removed 'ModelTags' import * Ran make style * fix: remove useless token (#1765) * Retry on ConnectionError/ReadTimeout when streaming file from server (#1766) * Retry on ConnectionError/ReadTimeout when streaming file from server * add test * fix testing utils * Adding `InferenceClient.get_recommended_model` (#1770) * Moved logger info to InferenceClient, so get_recommended_model function can bypass that * Added get_recommended_model to InferenceClient * Ran make style to generate the async client * Added tests of get_recommended_model * Update src/huggingface_hub/inference/_client.py Co-authored-by: Lucain <lucainp@gmail.com> * Fixed ordering of logger info and _get_recommended_model, for model string to have been populated * Removed _get_recommended_model private function, in favor of get_recommended_model in InferenceClient * Fixed wording of ValueError to use 'model' not 'task' * Ran make style for AsyncInferenceClient --------- Co-authored-by: Lucain <lucainp@gmail.com> * Fix document link for manage-cache (#1774) * Fix document link for manage-cache * Use redirects in _redirects.yml * Update docs/source/en/package_reference/file_download.md --------- Co-authored-by: Lucain <lucainp@gmail.com> * Minor doc fixes (#1775) * Don't use `api` in `list_repo_refs` example. * Minor typo fssepc -> fsspec * Use `.item_object_id` instead of `._id` * Ran make style --------- Co-authored-by: Remy <remy@huggingface.co> Co-authored-by: Lucain <lucainp@gmail.com> Co-authored-by: James Braza <jamesbraza@gmail.com> Co-authored-by: liuxueyang <liuxueyang457@gmail.com> Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small fixes I found while playing with the collections and repo APIs.