Reset _nb_retries if data has been received from the server
#1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Oct 31, 2023
|
Great, merging now then :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1766, I have introduced a retry mechanism in the download process if a
ConnectionErrororReadTimeouterror happens. The mechanism is quite simple: retry up to 5 times, wait 1s in between.This PR modifies this mechanism to reset the number of retries each time new data is received from the server. This is because (IMO) we should not assume before-hand how many retries will be needed to download a huge file on a slow connection. The only thing we want to avoid is to end up in an infinite loop, which cannot be the case here. Worst case is we retry 5 times between each chunk of data (very unlikely 😄)
(Failing tests are unrelated. I'm trying to fix them separately)