Add support for progress bars in hf_transfer uploads #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
cbensimon
reviewed
Nov 6, 2023
src/huggingface_hub/lfs.py
Outdated
Comment on lines
416
to
417
| if not supports_callback: | ||
| progress.update(total) |
There was a problem hiding this comment.
Maybe that this could be done outside of the try block ?
cbensimon
approved these changes
Nov 6, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following
hf_transferupdate (see huggingface/hf_transfer#18) and related to #1792 (progress bars while downloading).Progress bars are now enabled in
hf_transfer. This PR add support for it when uploading files. Implementation is still backward compatible with previous versions.Kudos to @cbensimon for the Rust implementation.