Fix HfFileSystemFile when init fails + improve error message
#1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks for the quick approval 😉 Should be released soon btw :) |
Wauplin
deleted the
1800-better-error-message-in-hffs-if-repo-not-found
branch
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
mariosasko
reviewed
Nov 6, 2023
| @@ -413,7 +413,21 @@ class HfFileSystemFile(fsspec.spec.AbstractBufferedFile): | |||
| def __init__(self, fs: HfFileSystem, path: str, revision: Optional[str] = None, **kwargs): | |||
| super().__init__(fs, path, **kwargs) | |||
| self.fs: HfFileSystem | |||
| self.resolved_path = fs.resolve_path(path, revision=revision) | |||
|
|
|||
| mode = kwargs.get("mode", "r") | |||
There was a problem hiding this comment.
fsspec's AbstractBufferedFile has "rb" as the default mode...
There was a problem hiding this comment.
Oh ok, thanks for letting me know. I'll open a follow-up PR to update that but in any case it doesn't change anything (this value is used only to check if it's "w" or "wb")
There was a problem hiding this comment.
I've made this commit (18d0ae2) to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1800 (?)
This PR does 2 things:
HfFileSystemFile.__init__fails because repo/revision do not exist,self.resolved_pathis not set. As a consequence the magic__del__(called just after since init failed) also fails because the file cannot be closed. This PR fixes this by not closing the file ifresolved_pathis not set.FileNotFoundErrorerror message is improved to let the user know why the file is not found (either repo not found, repo_id not valid or revision not found). Also mentions to the user that the repo must exist before writing a file to it. @lhoestq please let me know what you think of the updated message.I am not a big fan of auto-creating the repo/revision if not found. Biggest problem is that we would need to provide additional information (typically should it be created as
private? and if it is a Space repo, which sdk to specify?). I think for now improving the error message is already a good enough solution.