Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove maxdepth param from HfFileSystem.glob #1875

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Remove maxdepth param from HfFileSystem.glob #1875

merged 1 commit into from
Nov 29, 2023

Conversation

mariosasko
Copy link
Contributor

maxdepth was added to the default fsspec's glob in version 2023.9.0, so this PR removes maxdepth from the HfFileSystem.glob's signature to avoid an error in the older fsspec versions.

Fix #1872

@mariosasko mariosasko requested a review from Wauplin November 29, 2023 15:17
@mariosasko mariosasko mentioned this pull request Nov 29, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lhoestq
lhoestq approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

Wauplin
Wauplin approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mariosasko 👍

@Wauplin Wauplin merged commit 559fe63 into main Nov 29, 2023
15 of 16 checks passed
@Wauplin Wauplin deleted the fix-fs-maxdepth-glob branch November 29, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mariosasko @HuggingFaceDocBuilderDev @Wauplin @lhoestq