Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove respect_gitignore parameter #1876

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Remove respect_gitignore parameter #1876

merged 2 commits into from
Nov 30, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 30, 2023

Followup after #1868 (comment).

Let's remove the respect_gitignore: bool parameter completely as we don't expect users would want to force commit files.

@Wauplin Wauplin mentioned this pull request Nov 30, 2023
Merged
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

LysandreJik
LysandreJik approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed that's cleaner. Thanks for the quick turnaround!

@Wauplin Wauplin merged commit 8c848ca into main Nov 30, 2023
2 of 3 checks passed
@Wauplin Wauplin deleted the remove-respect-gitignore-param branch November 30, 2023 16:57
@julien-c
Copy link
Member

julien-c commented Dec 1, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@julien-c julien-c Awaiting requested review from julien-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wauplin @HuggingFaceDocBuilderDev @julien-c @LysandreJik