Catch SecretNotFoundError in google colab login
#1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
- Coverage 82.25% 82.22% -0.03%
==========================================
Files 65 65
Lines 8029 8030 +1
==========================================
- Hits 6604 6603 -1
- Misses 1425 1427 +2 ☔ View full report in Codecov by Sentry. |
|
Thanks for the review! Yes very nice QoL I think. Looking forward for releasing this! (early next week?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Colab introduced a new exception
SecretNotFoundErrorthat is raised when trying to access a secret that does not exist in the user vault. This PR adapts the Colab login integration to catch this error instead of relying on reading the error message itself.I've also updated the warning messages to be displayed on multiple lines otherwise it results in one gigantic line that no-one will ever read ^^