Improve snapshot_download offline mode
#1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
Dec 15, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Dec 19, 2023
…uggingface/huggingface_hub into improve-snapshot-download-offline-mode
|
Thanks for the thorough review! I've updated the error message that was wrong. I'll wait for the CI to complete and merge it to include it in next release :) |
|
Failing test is unrelated. Let's get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up after #1899 and huggingface/diffusers#6168 (comment).
At the moment if
snapshot_downloadfails because of a connection error, because repo not found, because Hub is down, etc., we do not try to locate the cached snapshot directory. This is not consistent with 1. what happens inhf_hub_downloadand 2. what happens insnapshot_downloaditself if local_files_only/HF_HUB_OFFLINE is set. This PR fixes this by adapting the existing workflow ofhf_hub_downloadtosnapshot_download. It should helpdiffusersusers that have an unstable connection to load their weights when already cached.Note: it should help but once this is shipped we would still need to adapt
diffusersimplementation as well. At the moment diffusers make at least amodel_infoto check file names (if I remember correctly). This call would have to handle theOfflineModeIsEnablederror as well.