Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local_dir on hf_hub_download edge case #1919

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix local_dir on hf_hub_download edge case #1919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c245d4
Fix to_local_dir on hf_hub_download edge case
Wauplin Dec 18, 2023
de29a58
Merge branch 'main' into 1909-fix-to-local-dir-on-edge-cases
Wauplin Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/huggingface_hub/file_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,6 +1417,8 @@ def hf_hub_download(
# If the download just completed while the lock was activated.
if os.path.exists(pointer_path) and not force_download:
# Even if returning early like here, the lock will be released.
if local_dir is not None:
return _to_local_dir(pointer_path, local_dir, relative_filename, use_symlinks=local_dir_use_symlinks)
return pointer_path

if resume_download:
Expand Down
Loading