Add optional truncate and normalize parameters to InferenceClient.feature_extraction()
#1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for opening a PR @awinml! The contribution is appreciated but I'd prefer to delay it for now as explained in #1939 (comment). |
Author
|
Closing in favour of #2270. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
fixes #1939
Proposed Changes:
Adds two new optional boolean parameters parameters to
InferenceClient.feature_extraction():truncate: If set to True, truncates inputs longer than 512 tokens. Defaults to True.normalize: If set to true, returned vectors will have length 1. Defaults to True.This enables using these parameters with endpoints set up using text-embeddings-inference.