improve http_get #1954
Merged
improve http_get #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 82.40% 82.43% +0.02%
==========================================
Files 66 66
Lines 8140 8135 -5
==========================================
- Hits 6708 6706 -2
+ Misses 1432 1429 -3 ☔ View full report in Codecov by Sentry. |
julien-c
reviewed
Jan 8, 2024
src/huggingface_hub/file_download.py
Outdated
| resume_size: float = 0, | ||
| headers: Optional[Dict[str, str]] = None, | ||
| expected_size: Optional[int] = None, | ||
| filename: Optional[str] = None, |
There was a problem hiding this comment.
maybe display_filename to emphasize that it's not the filename where the file is going to be saved at?
There was a problem hiding this comment.
Good idea. Removed in 6724e6c.
julien-c
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1942 (and in general should make this part more robust, it's not the first time we need to arrange this 😬).
When downloading a file, a progress bar is displayed. The title of the progress bar shows the filename of the file currently being downloaded. This displayed filename is either taken from the URL for non-LFS files or from the
Content-dispositionheader if hosted on a CDN -based on a regex. The PR changes this by adding a new -optional- parameter tohttp_getto pass the filename explicitly. This will definitely fix the issue by avoiding to "guess" the filename (#1942 is about an encoding issue for files like日本語/でこんにちは.jpg).The parameter is made optional because
cached_file(deprecated) cannot provide a filename. In general, the new parameter will be used in allhf_hub_download=> i.e. all the time.