Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HfFileSystem] Fix rm on branch #1957

Merged
merged 3 commits into from
Jan 9, 2024
Merged

[HfFileSystem] Fix rm on branch #1957

merged 3 commits into from
Jan 9, 2024

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Jan 4, 2024

This code returns EntryNotFoundError even if the file exists

fs.rm("datasets/username/datasetname@branch/data.txt")

and would only work on main.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36ad912) 82.44% compared to head (35ba031) 82.52%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   82.44%   82.52%   +0.08%     
==========================================
  Files          66       66              
  Lines        8138     8154      +16     
==========================================
+ Hits         6709     6729      +20     
+ Misses       1429     1425       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this @lhoestq! Do you mind adding a regression test for it in test_hf_file_system.py? Thanks in advance!

@Wauplin Wauplin requested a review from mariosasko January 5, 2024 11:19
Copy link
Contributor

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get it merged :)

@Wauplin Wauplin merged commit 2bdab6a into main Jan 9, 2024
16 checks passed
@Wauplin Wauplin deleted the fix-rm-on-branch branch January 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants