-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HfFileSystem.url
method
#2027
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 66 66
Lines 8240 8249 +9
==========================================
+ Hits 6788 6795 +7
- Misses 1452 1454 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition! Left a few nits but looks good to me :) Feel free to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks !
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes!
Adds a
url
method to theHfFileSystem
to simplify converting HF paths to HTTP URLs, which should be useful when working with libs that support HTTP URLs but notfsspec
paths as input/output (e.g.,webdataset
,polars
, etc.).PS: The
url
method is not part of the officialfsspec
specification, but popular filesystem implementations such asgcsfs
ands3fs
also have it