Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point out that the token must have write scope #2053

Merged
merged 5 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/huggingface_hub/utils/_errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,15 @@ def hf_raise_for_status(response: Response, endpoint_name: Optional[str] = None)
)
raise BadRequestError(message, response=response) from e

elif response.status_code == 403:
message = (
f"\n\n{response.status_code} Forbidden: {error_message}."
+ f"\nCannot access content at: {response.url}."
+ "\nIf you are trying to create or update content,"
+ "make sure you have a token with the `write` role."
)
raise HfHubHTTPError(message, response=response) from e

# Convert `HTTPError` into a `HfHubHTTPError` to display request information
# as well (request id and/or server error message)
raise HfHubHTTPError(str(e), response=response) from e
Expand Down
13 changes: 13 additions & 0 deletions tests/test_utils_errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,19 @@ def test_hf_raise_for_status_401_repo_url(self) -> None:
self.assertEqual(context.exception.response.status_code, 401)
self.assertIn("Request ID: 123", str(context.exception))

def test_hf_raise_for_status_403_wrong_token_scope(self) -> None:
response = Response()
response.headers = {"X-Request-Id": 123, "X-Error-Message": "specific error message"}
response.status_code = 403
response.request = PreparedRequest()
response.request.url = "https://huggingface.co/api/repos/create"
expected_message_part = "403 Forbidden: specific error message"
with self.assertRaisesRegex(HfHubHTTPError, expected_message_part) as context:
hf_raise_for_status(response)

self.assertEqual(context.exception.response.status_code, 403)
self.assertIn("Request ID: 123", str(context.exception))

def test_hf_raise_for_status_401_not_repo_url(self) -> None:
response = Response()
response.headers = {"X-Request-Id": 123}
Expand Down
Loading