Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized tests #2054

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Optimized tests #2054

merged 2 commits into from
Feb 28, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Feb 28, 2024

In the tests we are currently listing all Spaces on the Hub 3 times. This is not necessary and takes a huge amount of time (almost 1min only for that). This PR fixes this :)

@Wauplin Wauplin requested a review from LysandreJik February 28, 2024 11:28
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (47fc293) to head (7985af8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          71       71           
  Lines        8519     8519           
=======================================
  Hits         6870     6870           
  Misses       1649     1649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

let's make CI fast!

@Wauplin Wauplin merged commit 86fa26d into main Feb 28, 2024
17 checks passed
@Wauplin Wauplin deleted the optimize-tests branch February 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants