-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable python-xdist
on all tests
#2059
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 71 71
Lines 8519 8519
=======================================
Hits 6875 6875
Misses 1644 1644 ☔ View full report in Codecov by Sentry. |
Thanks for the wrap-up @bmuskalla! I still can't believe we were just one parameter away from enabling xdist in the CI without breaking any tests 😄 Regarding
Regarding this, the split is indeed for historical reasons when repository tests were taking much longer than the other tests. Here we could even divide Windows CI into 2 splits (repo and not repo) to reduce the overall CI but might be overkill. We can also reunify everything to reduce complexity. Let's keep those questions for later (I just opened #2062 not to forget) since this PR can be merged as-is and benefit everything right away! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for taking care of looking into this and benchmarking the improvement @bmuskalla! Let's get it merged! 🚀
Enable
python-xdist
on all tests. This reduces overall test execution by 55% on CI down to a around 6min (from 12min).After experimenting, using 4 instead of
auto
processes seems to avoid too much context trashing.-n auto
-n 4
Open questions:
"Repository only"
tests keep using-n 4
vs-n auto
(rate limit concerns)