Fix commonpath in read-only filesystem #2073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When downloading a model,
commonpath
is defined as the LCA (Lowest Common Ancestor) of huggingface's cachedir and target output directory. When this ends-up being a directory that is not read-only (e.g./
), an OSError (errno: 30) is thrown.This PR catches that error and tries to check symlink creation in the destination directory.
To reproduce
Original behaviour
Tested on MacOS 14.1.2 and python 3.11.4, the output was:
New behaviour
The model is persisted as intended.