Start defining custom errors in one place #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
changed the title
Wauplin
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Thanks for kicking off this topic @Y4suyuki! This PR is exactly what we aim for. If that's fine with you, I'll be enthusiastic to merge this one now so that we have a base example and then you (or other contributors?) can continue moving other errors to this file. Thanks again, that will be a great DX improvement! 🚀
|
@Wauplin Sure! I'll keep working on rest of errors. |
|
Failed tests are unrelated to this PR. Let's get this first one merged! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define all custom errors in
./src/huggingface_hub/errors.py.#2069