Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated guides/community.md to Korean #2126

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

seoulsky-field
Copy link
Contributor

@seoulsky-field seoulsky-field commented Mar 18, 2024

What does this PR do?

Translated the guides/community.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@cjfghk5697 cjfghk5697 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고칠게 안보여서.. 힘들게 문법 오류 하나 찾아서 리뷰 올렸습니다. 고생하셨습니다!

# 19 - Add Flax weights by ArthurZ, pr: True
```

`HfApi.get_repo_discussions`는 [`Discussion`] 객체를 생성하는 [제너레이터](https://docs.python.org/3.7/howto/functional.html#generators)를 반환합니다. 모든 토론들을 하나의 목록으로 가져오려면 다음을 실행합니다:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`HfApi.get_repo_discussions`[`Discussion`] 객체를 생성하는 [제너레이터](https://docs.python.org/3.7/howto/functional.html#generators)를 반환합니다. 모든 토론들을 하나의 목록으로 가져오려면 다음을 실행합니다:
`HfApi.get_repo_discussions`[`Discussion`] 객체를 생성하는 [제너레이터](https://docs.python.org/3.7/howto/functional.html#generators)를 반환합니다. 모든 토론을 하나의 목록으로 가져오려면 다음을 실행합니다:

'모든' 자체가 복수이기에, 접미사 '-들'을 지웠습니다!

Copy link
Contributor Author

@seoulsky-field seoulsky-field Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다! 관련 사항이 궁금하여 찾아보니, 국립국어원에서 답변한 내용을 참고하였을 때, 모든 뒤에 복수 명사가 나와도 괜찮은 것 같습니다..!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 몰랐네요.. 그러면 이외에는 특별히 없는거 같습니다!!

Copy link
Contributor

@boyunJang boyunJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 작업하느라 고생 많았습니다!! Discussions랑 Pull Request가 원문에 대문자로 표기되어 있길래 고유명사로 보여서 원문 그대로 변경했고, 그 점 외에는 변경할 부분이 크게 없었습니다! 확인 부탁드려요:)

docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깨진 글자 수정하였습니다!

docs/source/ko/guides/community.md Outdated Show resolved Hide resolved
Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>
@seoulsky-field seoulsky-field marked this pull request as ready for review April 2, 2024 01:05
@jungnerd
Copy link
Contributor

jungnerd commented Apr 5, 2024

@Wauplin This PR looks good to me!
May you please merge this PR?

@Wauplin
Copy link
Contributor

Wauplin commented Apr 5, 2024

May you please merge this PR?

Yes! Thanks @seoulsky-field @jungnerd! 🎉

@Wauplin Wauplin merged commit 619ffd0 into huggingface:main Apr 5, 2024
awgr pushed a commit to awgr/huggingface_hub that referenced this pull request Apr 7, 2024
)

* docs: ko: guides/community.md

* feat: nmt draft

* fix: manual edits

* fix: resolve suggestions

Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>

---------

Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>
awgr pushed a commit to awgr/huggingface_hub that referenced this pull request Apr 7, 2024
)

* docs: ko: guides/community.md

* feat: nmt draft

* fix: manual edits

* fix: resolve suggestions

Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>

---------

Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants