Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated guides/search.md to Korean #2134

Merged
merged 10 commits into from
Apr 9, 2024
Merged

🌐 [i18n-KO] Translated guides/search.md to Korean #2134

merged 10 commits into from
Apr 9, 2024

Conversation

seoyoung-3060
Copy link
Contributor

@seoyoung-3060 seoyoung-3060 commented Mar 20, 2024 •
edited
Loading

What does this PR do?

Translated the guides/search.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

jungnerd
jungnerd reviewed Mar 24, 2024
View reviewed changes
docs/source/ko/guides/search.md Outdated
rendered properly in your Markdown viewer.
-->

# 허브에서 검색하기
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 허브에서 검색하기
# 허브에서 검색하기[[search-the-hub]]

Anchor를 추가해주세요!

seoulsky-field
seoulsky-field reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다! 허브->Hub와 레포지토리->리포지토리, Anchor 추가, 단어 일관성 (스페이스 vs. 공간), 링크 누락 부분을 수정하였습니다. 확인 부탁드립니다!

docs/source/ko/guides/search.md Outdated

이 튜토리얼에서는 `huggingface_hub`를 사용하여 허브에서 모델, 데이터 세트 및 공간을 검색하는 방법을 배웁니다.

## 레포지토리를 어떻게 나열하나요?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 레포지토리를 어떻게 나열하나요?
## 레포지토리를 어떻게 나열하나요?[[how-to-list-repositories-]]

Anchor 추가해주세요!

docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated
>>> models = api.list_models()
```

[`list_models`]의 출력은 허브에 저장된 모델들을 순회할 수 있는 반복자입니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[`list_models`]의 출력은 허브에 저장된 모델들을 순회할 수 있는 반복자입니다.
[`list_models`]의 출력은 Hub에 저장된 모델들을 순회할 수 있는 반복자입니다.

허브 -> Hub 국문 번역하지 않고 영문으로 두었습니다!

docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated

마찬가지로, [`list_datasets`]를 사용하여 데이터셋을 나열하고 [`list_spaces`]를 사용하여 스페이스를 나열할 수 있습니다.

## 레포지토리를 어떻게 필터링하나요?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 레포지토리를 어떻게 필터링하나요?
## 레포지토리를 어떻게 필터링하나요?[[how-to-filter-repositories-]]

Anchor 추가하였습니다!

docs/source/ko/guides/search.md Outdated

## 레포지토리를 어떻게 필터링하나요?

레포지토리를 나열하는 것도 유용하지만, 이제 검색을 필터링하고 싶을 수도 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
레포지토리를 나열하는 것도 유용하지만, 이제 검색을 필터링하고 싶을 수도 있습니다.
리포지토리를 나열하는 것도 유용하지만, 이제 검색을 필터링하고 싶을 수도 있습니다.

딥러닝 용어사전에 근거하여 레포지토리가 아닌 리포지토리를 사용하였습니다.

docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
seoulsky-field
seoulsky-field reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space 관련 사항 수정 및 추가하였습니다.

docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
boyunJang
boyunJang reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@boyunJang boyunJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 작업하느라 고생 많으셨습니다!! 검토를 살짝 늦게 했는데, @seoulsky-field 님께서 검토를 너무 잘 해주셔서... 중간중간 빠진 부분들 조금씩 수정했습니다! 확인 부탁드려요:)

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
docs/source/ko/guides/search.md Outdated Show resolved Hide resolved
seoyoung-3060 and others added 2 commits March 28, 2024 23:24
@seoyoung-3060 @boyunJang @seoulsky-field
fix: resolve suggestions
62194ee 
Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
@seoyoung-3060
Merge branch 'main' into ko-guides/search.md
6b82898
@seoyoung-3060 seoyoung-3060 marked this pull request as ready for review March 28, 2024 14:29
@heuristicwave
Copy link
Contributor

@Wauplin This translation has been reviewed, please merge it :)

@jungnerd
Copy link
Contributor

jungnerd commented Apr 9, 2024

@Wauplin I also reviewed this PR. LGTM!

Wauplin
Wauplin approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Merging it :) And sorry not noticing last week ping, also an oversight on my side.

Thanks @seoyoung-3060 for your contribution! 🤗 EDIT: thanks to everyone involved in this community effort!!

@Wauplin Wauplin merged commit 2bb71da into huggingface:main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seoulsky-field seoulsky-field seoulsky-field left review comments

@jungnerd jungnerd jungnerd left review comments

@boyunJang boyunJang boyunJang left review comments

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@seoyoung-3060 @HuggingFaceDocBuilderDev @heuristicwave @jungnerd @Wauplin @boyunJang @seoulsky-field