Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated guides/inference_endpoints.md to Korean #2164

Merged
merged 21 commits into from
Apr 25, 2024

Conversation

usr-bin-ksh
Copy link
Contributor

@usr-bin-ksh usr-bin-ksh commented Mar 28, 2024

What does this PR do?

Translated the guides/inference_endpoints.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@boyunJang boyunJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 작업하느라 수고하셨습니다!! 중간중간 조금씩 수정했는데, 반영할 만한 수정사항들만 확인해주시면 감사하겠습니다:)

docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
usr-bin-ksh and others added 2 commits April 24, 2024 14:46
Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>
@usr-bin-ksh usr-bin-ksh marked this pull request as ready for review April 24, 2024 05:52
Copy link
Contributor

@heuristicwave heuristicwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 조금 더 읽기 쉽게 바꿔 보았습니다

docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
docs/source/ko/guides/inference_endpoints.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@usr-bin-ksh usr-bin-ksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: resolve suggestes

Copy link
Contributor Author

@usr-bin-ksh usr-bin-ksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: resolve suggestes

usr-bin-ksh and others added 10 commits April 25, 2024 11:06
fix:resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
fix: resolve suggestions

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>
@jungnerd
Copy link
Contributor

@Wauplin LGTM 👍 I think this PR is good to merge!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Wauplin Wauplin merged commit 3f684c1 into huggingface:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants